Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PaymentsV4 implementation #34

Open
wants to merge 111 commits into
base: master
Choose a base branch
from
Open

Add PaymentsV4 implementation #34

wants to merge 111 commits into from

Conversation

andra-simionov
Copy link
Contributor

No description provided.

trydocatch
trydocatch previously approved these changes Jun 16, 2020
Copy link
Collaborator

@trydocatch trydocatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good

@@ -28,7 +28,7 @@ final class AluV3 implements AuthorizationPaymentsApiClient
* @var array
*/
private $aluUrlHostname = [
//'ro' => 'https://secure.payu.ro',
'ro' => 'https://secure.payu.ro',
'ru' => 'http://ru.payu.local',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have local endpoints here.

horatiubrinza
horatiubrinza previously approved these changes Jun 19, 2020
Copy link

@horatiubrinza horatiubrinza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ready to be merged.

@drealecs drealecs dismissed stale reviews from horatiubrinza and trydocatch via 783941b July 4, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants